Ignore devfile-web snyk scanning#301
Conversation
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
michael-valdron
requested review from
Jdubrick,
JslYoon,
johnmcollier and
thepetk
thepetk
left a comment
thepetk
left a comment
There was a problem hiding this comment.
@michael-valdron let's hold a bit, it didn't worked as expected in alizer. I'll take a second look and see if I have missed something on their docs
thepetk
left a comment
thepetk
left a comment
There was a problem hiding this comment.
Took a second look in the docs and I feel we are using the correct format. We might need to wait a bit longer for the ignore command to be effective.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
@thepetk Agreed, my main here is to suppress most of them opening for the main dependencies of devfile-web, can address anything else getting patched by snyk here in a follow up PR. |
2 participants
Description of Changes
Summarize the changes you made as part of this pull request.
We use dependabot for security scans instead of snyk, automation activated outside our team, these changes should suppress snyk scanning in this repository.
Related Issue(s)
Link the GitHub/GitLab/JIRA issues that are related to this PR.
Acceptance Criteria
Update the sidebar if there is a new file added or an existing filename is changed
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.